Enhancement: Configure preferred installation source in composer.json #10774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @localheinz, thank you for your contributions! I saw you submitted a couple of PRs recently, would you mind using the suggested templates from now on and adjusting the PRs to the template please? |
|
Of course! 👍 |
|
Build failure is unrelated to the changes in this PR. |
magento-team
pushed a commit
that referenced
this pull request
Sep 6, 2017
magento-team
pushed a commit
that referenced
this pull request
Sep 6, 2017
[EngCom] Public Pull Requests - MAGETWO-72350: Fix: Use all columns when running tests #10784 - MAGETWO-72349: Fix: Move GitHub-specific documents into .github #10778 - MAGETWO-72344: Enhancement: Configure preferred installation source in composer.json #10774 - MAGETWO-72279: Always use https for Vimeo video's. #10768
|
Thank you, @miguelbalparda, @magento-team, and @orlangur! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By configuring the preferred method of installation in
composer.json, none of the flags--prefer-dist--prefer-sourceneed to be specified when installing dependencies.
Since it is indicated in
.travis.ymlthat dependencies should be installed fromdist(which of course makes the most sense), this PR configures thepreferred-installmethod accordingly.💁♂️ For reference, see https://getcomposer.org/doc/06-config.md#preferred-install.
Fixed Issues (if relevant)
n/a
Manual testing scenarios
n/a
Contribution checklist
Somewhat related to #10769.